Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all files to use local lib if existant #1118

Closed
wants to merge 48 commits into from
Closed

Update all files to use local lib if existant #1118

wants to merge 48 commits into from

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Feb 28, 2020

No description provided.

@szaimen szaimen mentioned this pull request Feb 29, 2020
6 tasks
@szaimen
Copy link
Collaborator Author

szaimen commented Feb 29, 2020

I think this is ready. Hence marking as ready for review
but @enoch85 do you have an idea why travis reports those shellcheck issues although they should be disabled?

@szaimen szaimen marked this pull request as ready for review February 29, 2020 02:30
@enoch85
Copy link
Member

enoch85 commented Feb 29, 2020

Big PR again... Will take some time to review.

Btw, /var/scripts/main - where does the "main" come from? We don't have that.

@szaimen
Copy link
Collaborator Author

szaimen commented Feb 29, 2020

Currently we don't have it but we will create it:
https://github.com/nextcloud/vm/pull/1120/files#diff-90b7ea30bc531dd051547e9ec21aeb32R19-R21

You have to see all PRs that are mentioned in the Issue "What is needed to fix #11" alltogether. I just split it up that you are able to review it. but all are made so that they work standalone.

@szaimen
Copy link
Collaborator Author

szaimen commented Feb 29, 2020

I changed the local path to the lib so that everyone who has the lib.sh in "$SCRIPTS" will not automatically use the local lib file, but at the same time we are able to move on, while staying backwards compatible. Because if we would use the "$SCRIPTS"/lib.sh file, all users who would run the app-scripts would always use the local lib.sh file which we don't want since it can be really outdated.
We could change that by removing the lib.sh file when running the apps_scripts but I think it makes sense to have a "main" folder because they aren't in the "$SCRIPTS" location which should only be fore files that can get executed.

@szaimen
Copy link
Collaborator Author

szaimen commented Feb 29, 2020

actually this PR should be fairly easy to review since I am only adding the possiblity to use the local lib if existant to all scripts. (just check out the code)
But I still need a hint why travis is reporting those shellcheck issues which should be disabled based on the code...

@szaimen
Copy link
Collaborator Author

szaimen commented Feb 29, 2020

closing in favour of #1124

@szaimen szaimen closed this Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants