Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Update broke docker #713

Closed
tiagoefreitas opened this issue Nov 18, 2018 · 18 comments
Closed

Latest Update broke docker #713

tiagoefreitas opened this issue Nov 18, 2018 · 18 comments
Labels

Comments

@tiagoefreitas
Copy link

With latest update I got this error:
Failed to start docker.service: Unit docker.socket not found

Trying to fix it, copied /lib/systemd/system/docker.service to /etc/systemd/system/ again, and added "--storage-driver=devicemapper" to ExecStart but it fails:

INFO[2018-11-18T20:59:44.991739905+01:00] parsed scheme: "unix" module=grpc
INFO[2018-11-18T20:59:44.991767056+01:00] scheme "unix" not registered, fallback to default scheme module=grpc
INFO[2018-11-18T20:59:44.991828102+01:00] parsed scheme: "unix" module=grpc
INFO[2018-11-18T20:59:44.991849189+01:00] scheme "unix" not registered, fallback to default scheme module=grpc
ERRO[2018-11-18T20:59:44.992001497+01:00] Failed to GetDriver graph driver=devicemapper error="graphdriver plugins are only supported with experimental mode" home-dir=/var/lib/docker

May want to fix onlyoffice.sh

@tiagoefreitas
Copy link
Author

Problem was ubuntu docker update missing devicemapper plugin, see here:

docker/for-linux#452

@enoch85 enoch85 added the bug label Nov 18, 2018
@enoch85
Copy link
Member

enoch85 commented Nov 18, 2018

Thanks for posting!

Let's wait and see if it will remain or if we (OnlyOffice, Collabora and everyone else using devicemapper) have to change to something else

@enoch85
Copy link
Member

enoch85 commented Nov 18, 2018

Could you please try a fresh install and see if it works with overlay2 instead here: https://github.com/nextcloud/vm/blob/master/apps/onlyoffice.sh#L83-L87?

Thanks!

@tiagoefreitas
Copy link
Author

Is devicemapper required?
I can't do a fresh install but I can try to change it and test.

@tiagoefreitas
Copy link
Author

tiagoefreitas commented Nov 18, 2018

Doesn't work for me, but my system is modified I'm running zfs on root filesystem with luks.

'overlay2' is not supported over zfs storage-driver=overlay2

Decided to revert docker-ce to previous version for now

@enoch85
Copy link
Member

enoch85 commented Nov 19, 2018

@tiagoefreitas Ah ok I see. It would be very helpful if you could put up a test system / VM just to test if it works with overlay2. In that case we'll change.

IIRC it didn't work with overlay2 and that's why we went with devicemapper.

@enoch85
Copy link
Member

enoch85 commented Nov 19, 2018

I just updated my server to the latest version (Ubuntu packages including Docker) and the Collabora docker image, everything is working even after a reboot. Hmm...

@enoch85
Copy link
Member

enoch85 commented Nov 19, 2018

OK, I just confirmed, it broke on my other server when changing to overlay2.

So I will hold the docker update for now.

@enoch85
Copy link
Member

enoch85 commented Nov 19, 2018

For referance: #546

@enoch85
Copy link
Member

enoch85 commented Nov 19, 2018

Posted bug report with Collabora: nextcloud/richdocuments#313

@enoch85
Copy link
Member

enoch85 commented Nov 19, 2018

And with Onlyoffice: ONLYOFFICE/docker-onlyoffice-nextcloud#3

@enoch85
Copy link
Member

enoch85 commented Nov 19, 2018

This is quite interesting though....

https://fribeiro.org/tech/2018/02/13/collabora-docker-nextcloud/

@tiagoefreitas
Copy link
Author

tiagoefreitas commented Nov 19, 2018 via email

@enoch85
Copy link
Member

enoch85 commented Nov 19, 2018

doesn’t support zfs...

You win some, you lose some. :)

@tiagoefreitas
Copy link
Author

tiagoefreitas commented Nov 20, 2018

Found this in docker info:
WARNING: devicemapper: usage of loopback devices is strongly discouraged for production use.
Use --storage-opt dm.thinpooldev to specify a custom block storage device.
WARNING: No swap limit support

It means performance can be improved?

I found when changing storage drivers, this needs to be done, will test better:
https://meta.discourse.org/t/how-to-change-storage-backend-in-docker/75352

Ended up changing to zfs and it works for me, even better performance than before.
Can work here too if you store docker inside the ncdata zfs pool.

Instructions here:
https://docs.docker.com/storage/storagedriver/zfs-driver/#configure-docker-with-the-zfs-storage-driver

@enoch85 enoch85 reopened this Nov 26, 2018
@enoch85
Copy link
Member

enoch85 commented Nov 26, 2018

@tiagoefreitas Do you think you could prepare a PR for storing it in ZFS? Would be great to have a future proof way of doing it since devicemapper isn't optimal.

@enoch85
Copy link
Member

enoch85 commented Nov 26, 2018

Or I maybe solved it with overlay2 instead. Let's see if Collabora works as well... Onlyoffice is fixed anyway.

@enoch85
Copy link
Member

enoch85 commented Nov 26, 2018

It works with Collabora as well. This issue is now fixed.

@enoch85 enoch85 closed this as completed Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants