Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for video captions #910

Closed
wants to merge 14 commits into from
Closed

Add support for video captions #910

wants to merge 14 commits into from

Commits on May 25, 2021

  1. Add support for video captions 

    Generate HTML5 subtitle tracks dynamically based on the contents of the folder
where the video is located.

For example: given a movie 'video.mkv', the player will look for VTT subtitle
files named 'video.XX.vtt' and '.video.XX.vtt', where XX is the two-letter
code for the language.

Signed-off-by: Frederic Ruget <[email protected]>
    @douzebis @beardhatcode
    douzebis authored and beardhatcode committed May 25, 2021
    Configuration menu
    Copy the full SHA
    9cb6408 View commit details
    Browse the repository at this point in the history

  2. Fix typo in condition 

    Signed-off-by: Frederic Ruget <[email protected]>
    @douzebis @beardhatcode
    douzebis authored and beardhatcode committed May 25, 2021
    Configuration menu
    Copy the full SHA
    088b678 View commit details
    Browse the repository at this point in the history

  3. Use v-for instead of v-html to create tracks 

    Signed-off-by: Frederic Ruget <[email protected]>
    @douzebis @beardhatcode
    douzebis authored and beardhatcode committed May 25, 2021
    Configuration menu
    Copy the full SHA
    f2216ad View commit details
    Browse the repository at this point in the history

  4. Simplify the code (no need for extra async function) 

    Signed-off-by: Frederic Ruget <[email protected]>
    @douzebis @beardhatcode
    douzebis authored and beardhatcode committed May 25, 2021
    Configuration menu
    Copy the full SHA
    e1eacde View commit details
    Browse the repository at this point in the history

  5. Get rid of v-html (and associated warning) 

    Instead fetchTracks() can be called from options().

Signed-off-by: Frederic Ruget <[email protected]>
    @douzebis @beardhatcode
    douzebis authored and beardhatcode committed May 25, 2021
    Configuration menu
    Copy the full SHA
    f681942 View commit details
    Browse the repository at this point in the history

  6. Add js/viewer-main.js* (necessary??) 

    Signed-off-by: Frederic Ruget <[email protected]>
    @douzebis @beardhatcode
    douzebis authored and beardhatcode committed May 25, 2021
    Configuration menu
    Copy the full SHA
    ce00b04 View commit details
    Browse the repository at this point in the history

  7. Clean up (cosmetic) 

    Signed-off-by: Frederic Ruget <[email protected]>
    @douzebis @beardhatcode
    douzebis authored and beardhatcode committed May 25, 2021
    Configuration menu
    Copy the full SHA
    1362f92 View commit details
    Browse the repository at this point in the history

  8. Fix typo (lang -> srclang) 

    Signed-off-by: Frederic Ruget <[email protected]>
    @douzebis @beardhatcode
    douzebis authored and beardhatcode committed May 25, 2021
    Configuration menu
    Copy the full SHA
    15d412e View commit details
    Browse the repository at this point in the history

  9. Improve code readability -- use: for (item of items) 

    Signed-off-by: Frederic Ruget <[email protected]>
    @douzebis @beardhatcode
    douzebis authored and beardhatcode committed May 25, 2021
    Configuration menu
    Copy the full SHA
    be25019 View commit details
    Browse the repository at this point in the history

  10. fixup! Improve code readability -- use: for (item of items) 

    Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
    @npmbuildbot-nextcloud @beardhatcode
    npmbuildbot-nextcloud[bot] authored and beardhatcode committed May 25, 2021
    Configuration menu
    Copy the full SHA
    9f05ce1 View commit details
    Browse the repository at this point in the history

  11. Fix issue with tracks not always being reactive 

    Property track was not properly declared, and sometimes was not
reactive. E.g. closing and re-opening the player would make
subtitles disappear.

Fixing entails declaring tracks in the data() function associated
with the Videos vue.

Signed-off-by: Frederic Ruget <[email protected]>
    @douzebis @beardhatcode
    douzebis authored and beardhatcode committed May 25, 2021
    Configuration menu
    Copy the full SHA
    d4c9014 View commit details
    Browse the repository at this point in the history

  12. Move fetchData() from template to methods 

    (Templates are not made to call methods.)

Signed-off-by: Frederic Ruget <[email protected]>
    @douzebis @beardhatcode
    douzebis authored and beardhatcode committed May 25, 2021
    Configuration menu
    Copy the full SHA
    01fc82e View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. Try and fix the mess I did with github 'fetch upstream'

    @douzebis
    douzebis committed May 27, 2021
    Configuration menu
    Copy the full SHA
    a9cfee1 View commit details
    Browse the repository at this point in the history

  2. Try and fix the mess I did with github 'fetch upstream'

    @douzebis
    douzebis committed May 27, 2021
    Configuration menu
    Copy the full SHA
    31cb81a View commit details
    Browse the repository at this point in the history