Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix: Make loading the viewer an init script #2491

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 11, 2024

Backport of #2486

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Strongly based on https://github.com/nextcloud/viewer/pull/2490/files

@backportbot backportbot bot requested review from mejo- and susnux September 11, 2024 18:18
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews labels Sep 11, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.10 milestone Sep 11, 2024
@susnux susnux force-pushed the backport/2486/stable28 branch 2 times, most recently from e3c331d to 83d5301 Compare September 11, 2024 20:52
@skjnldsv
Copy link
Member

@susnux can you fix the conflicts?

@artonge artonge force-pushed the backport/2486/stable28 branch 2 times, most recently from 4ab769b to 78259ac Compare October 3, 2024 13:36
@artonge artonge marked this pull request as ready for review October 3, 2024 13:36
@artonge

This comment was marked as outdated.

@artonge

This comment was marked as outdated.

1 similar comment
@artonge

This comment was marked as outdated.

@artonge artonge force-pushed the backport/2486/stable28 branch 3 times, most recently from e84d354 to a0a1576 Compare October 10, 2024 14:54
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
@artonge

This comment was marked as outdated.

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
@artonge
Copy link
Contributor

artonge commented Oct 15, 2024

/compile amend /

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge merged commit 723467d into stable28 Oct 15, 2024
28 checks passed
@artonge artonge deleted the backport/2486/stable28 branch October 15, 2024 13:36
@Altahrim Altahrim mentioned this pull request Oct 30, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants