Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable viewer for image/emf #2065

Merged
merged 1 commit into from
Nov 16, 2023
Merged

feat: enable viewer for image/emf #2065

merged 1 commit into from
Nov 16, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Nov 12, 2023 •
edited
Loading

For nextcloud/files_emfviewer#1

Add support for image/emf files through a generated preview.

The actual implementation, to generate a preview image, will be provided via app or server.

@kesselb kesselb self-assigned this Nov 12, 2023
@kesselb kesselb added enhancement New feature or request 3. to review Waiting for reviews labels Nov 12, 2023
@kesselb kesselb mentioned this pull request Nov 12, 2023
Merged
7 tasks
@kesselb kesselb added this to the Nextcloud 28 milestone Nov 12, 2023
@blizzz blizzz mentioned this pull request Nov 13, 2023
Merged
ChristophWurst
ChristophWurst approved these changes Nov 13, 2023
View reviewed changes
src/models/images.js Outdated Show resolved Hide resolved
@kesselb
feat: enable viewer for image/emf
fa1b768 
Add support for image/emf files through a generated preview.

Signed-off-by: Daniel Kesselberg <[email protected]>
@szaimen
Copy link
Contributor

szaimen commented Nov 13, 2023

What happens if the files_emfviewer app is not installed or the preview provider not enalbed? does it show an error or just bug out?

@st3iny
Copy link
Member

st3iny commented Nov 13, 2023 •
edited
Loading

What happens if the files_emfviewer app is not installed or the preview provider not enalbed? does it show an error or just bug out?

The default behaviour (for unsupported files) will be enabled: Files will just be downloaded when clicking on them.

st3iny
st3iny approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@kesselb kesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 13, 2023
@blizzz blizzz mentioned this pull request Nov 14, 2023
Merged
ChristophWurst
ChristophWurst approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

The trick is to compile the frontend code so the changes are actually active 😎

@ChristophWurst
Copy link
Member

suspicious how CI passes with outdated files?

        modified:   js/viewer-main.js
        modified:   js/viewer-main.js.LICENSE.txt
        modified:   js/viewer-main.js.map

@kesselb
Copy link
Contributor Author

kesselb commented Nov 16, 2023 •
edited
Loading

suspicious how CI passes with outdated files?

The JS files are built and pushed automatically #1982

@ChristophWurst
Copy link
Member

cypress is sad. restart doesn't help much

@ChristophWurst
Copy link
Member

most recent commits on master as just as red as the cypress runs here. I think we can merge 😎

@ChristophWurst ChristophWurst merged commit 4af3f4a into master Nov 16, 2023
24 of 27 checks passed
@ChristophWurst ChristophWurst deleted the hello-emf branch November 16, 2023 19:31
@ChristophWurst ChristophWurst mentioned this pull request Nov 23, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@st3iny st3iny st3iny approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@kesselb kesselb

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@kesselb @szaimen @st3iny @ChristophWurst @JuliaKirschenheuter