Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to source if fileid is undefined #1806

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jul 13, 2023

This allows to open file's version. They currently do not have an associated fileid.

@artonge artonge added enhancement New feature or request 3. to review Waiting for reviews javascript Javascript related ticket labels Jul 13, 2023
@artonge artonge added this to the Nextcloud 28 milestone Jul 13, 2023
@artonge artonge requested a review from skjnldsv July 13, 2023 16:05
@artonge artonge self-assigned this Jul 13, 2023
@juliusknorr juliusknorr force-pushed the artonge/feat/default_to_source_if_no_fileid branch from df7c70c to 95319c9 Compare August 7, 2023 08:15
@juliusknorr
Copy link
Member

Those cypress tests also fail on master.

@juliusknorr juliusknorr merged commit 90cc58f into master Aug 7, 2023
23 of 26 checks passed
@juliusknorr juliusknorr deleted the artonge/feat/default_to_source_if_no_fileid branch August 7, 2023 10:29
@juliusknorr
Copy link
Member

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Aug 8, 2023
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants