Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable24] Use modern API to cancel requests #1249

Merged
merged 1 commit into from
May 30, 2022
Merged

[stable24] Use modern API to cancel requests #1249

merged 1 commit into from
May 30, 2022

Commits on May 17, 2022

  1. When double-clicking on a file, the behavior is: 

    First click: open the viewer
Second click: close the viewer

But the second click does not correctly close the Viewer, as the method used to cancel the requests does not work.

This PR use modern API to cancel the requests. The requests are now correctly aborted, and the `openFile` method exit because the request call throws an exception.

Fix #893

https://axios-http.com/docs/cancellation
https://developer.mozilla.org/en-US/docs/Web/API/AbortController

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
    @artonge @nextcloud-command
    artonge authored and nextcloud-command committed May 17, 2022
    Configuration menu
    Copy the full SHA
    5b203ee View commit details
    Browse the repository at this point in the history