-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do IMAP auth over direct socket connection #49
Conversation
Signed-off-by: Jonas Sulzer <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Jonas Sulzer <[email protected]>
Signed-off-by: Jonas Sulzer <[email protected]>
Signed-off-by: Jonas Sulzer <[email protected]>
This reverts commit 9df4e31.
Signed-off-by: Jonas Sulzer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Just a bit of information, I needed to use the following in the config.php: (I needed to explicitly use the mail server name, rather than 127.0.0.1, and I had to put single quotes around the ssl parameter, otherwise nextcloud had an error) 'user_backends' => array( |
@philtrick-twm yes, thank you, see #52 and #53 |
fixes #44
fixes #13
Like proposed in #44 we took the implementation of roundcube but stripped away everything that's not needed for the authentication.
ref: https://github.com/roundcube/roundcubemail/blob/master/program/lib/Roundcube/rcube_imap_generic.php
as we're not using the php-imap (imap_open) library, this dependency isn't needed any more, however we need some different parameters to be set, so the configuration is different and needs to be changed on running instances (see https://github.com/nextcloud/user_external/blob/ec7929ab6aaaf97eb05b419c9d5b82544d629959/README.md vs. the current one)
thank you very much @ChristophWurst for your help!
cc @nextcloud/user_external @hcderaad @patschi @andryyy @lsbbs