Distinguish wrong credentials from other problems (IMAP) #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verifying login data can fail for a number of reasons like temporary connection failure to the IMAP server, Internal problems of the IMAP server, or actually wrong username / password combination. This change logs the reason for login failures, helping server admins to diagnose login problems and better support their users. Ideally, we would have an option to pass the reason upwards, so the NextCloud login system can show appropriate errors to users attempting to login. Signed-off-by: Bjoern Kahl <[email protected]>
BjoKaSH
force-pushed
the
imap_log_failure_reason
branch
from
2ad7239
to
6948390
Compare
violoncelloCH
approved these changes
Apr 2, 2024
|
Thanks for the contribution @BjoKaSH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Verifying login data can fail for a number of reasons like temporary connection failure to the IMAP server, Internal problems of the IMAP server, or actually wrong username / password combination.
This change logs the reason for login failures, helping server admins to diagnose login problems and better support their users.
Ideally, we would have an option to pass the reason upwards, so the NextCloud login system can show appropriate errors to users attempting to login.