Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(execute): Let user know how to reset when a step has been cancelled in progress #472

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented May 4, 2023

fixes #459
fixes #272
fixes #453
fixes #451
fixes #396
fixes #245

@marcelklehr marcelklehr force-pushed the enh/mention-step-file-when-stuck branch from 047fbad to d052101 Compare May 4, 2023 09:43
index.php Show resolved Hide resolved
index.web.php Show resolved Hide resolved
index.php Show resolved Hide resolved
Copy link
Member

@solracsf solracsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comments, all good 👍

Copy link
Collaborator

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good apart from small typing remark

lib/Updater.php Show resolved Hide resolved
@marcelklehr
Copy link
Member Author

Should I try to make CI green? Not sure what's going on there

@come-nc
Copy link
Collaborator

come-nc commented May 9, 2023

@marcelklehr run make updater.phar and make index.php again

@marcelklehr marcelklehr force-pushed the enh/mention-step-file-when-stuck branch from ea1ef9b to 448f8f4 Compare May 16, 2023 15:53
@marcelklehr
Copy link
Member Author

@come-nc It won't budge. 🤷

@come-nc
Copy link
Collaborator

come-nc commented May 22, 2023

I fixed phar content, the master test is failing because currently the master zip ships some apps which are not advertising 28 support yet. Should be fixed in the next zip update because files_rightclick was fixed an hour ago.

@marcelklehr
Copy link
Member Author

@come-nc This is still waiting for a merge

marcelklehr and others added 3 commits July 27, 2023 15:53
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc force-pushed the enh/mention-step-file-when-stuck branch from 8c87e44 to ef7562e Compare July 27, 2023 13:54
@come-nc
Copy link
Collaborator

come-nc commented Jul 27, 2023

@come-nc This is still waiting for a merge

Rebased, all green now, but I do not have the rights to click merge.

@AndyScherzinger AndyScherzinger merged commit c47b3d5 into master Jul 28, 2023
21 checks passed
@AndyScherzinger AndyScherzinger deleted the enh/mention-step-file-when-stuck branch July 28, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants