Introduce Update Directory #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to specify a specific directory as updater working directory
blizzz
approved these changes
Jun 30, 2022
This was referenced Aug 12, 2022
Signed-off-by: Git'Fellow <[email protected]>
skjnldsv
approved these changes
Aug 23, 2022
solracsf
added a commit
to nextcloud/server
that referenced
this pull request
Aug 25, 2022
To be merged after nextcloud/updater#420 Signed-off-by: Git'Fellow <[email protected]>
1 task
Signed-off-by: Git'Fellow <[email protected]>
Signed-off-by: Git'Fellow <[email protected]>
Signed-off-by: Git'Fellow <[email protected]>
Signed-off-by: Git'Fellow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to use a specific directory as updater working directory.
This is 100% backwards compatible as, if not set (the default), fallback to default
datadirectoryconfig.sample.phpat https://github.com/nextcloud/server🆗 Done by nextcloud/server#33692
This serves 2 purposes:
datadirectoryis set on a slow filesystems (like NFS) update can be very slow, or even time out. On our tests, gain is 500% less time on upgrade when moving away from NFS to Block, as working on very small files on network filesystems is a pain.updatedirectoryis placed on the same disk where application resides, which is not always the same disk asdatadirectory, "Move new files in place" step is an atomic operation.