Merge pull request #561 from nextcloud/backport/556/stable26

[stable26] fix: Correctly check result of function
nextcloud · May 23, 2024 · 75ee915 · 75ee915
2 parents be2ed68 + b4d5139
commit 75ee915
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/index.php b/index.php
@@ -688,12 +688,12 @@ public function verifyIntegrity() {
 -----END CERTIFICATE-----
 EOF;
 
-		$validSignature = (bool)openssl_verify(
+		$validSignature = openssl_verify(
 			file_get_contents($this->getDownloadedFilePath()),
 			base64_decode($response['signature']),
 			$certificate,
 			OPENSSL_ALGO_SHA512
-		);
+		) === 1;
 
 		if ($validSignature === false) {
 			throw new \Exception('Signature of update is not valid');

diff --git a/lib/Updater.php b/lib/Updater.php
@@ -652,12 +652,12 @@ public function verifyIntegrity() {
 -----END CERTIFICATE-----
 EOF;
 
-		$validSignature = (bool)openssl_verify(
+		$validSignature = openssl_verify(
 			file_get_contents($this->getDownloadedFilePath()),
 			base64_decode($response['signature']),
 			$certificate,
 			OPENSSL_ALGO_SHA512
-		);
+		) === 1;
 
 		if ($validSignature === false) {
 			throw new \Exception('Signature of update is not valid');

diff --git a/updater.phar b/updater.phar