Fix/hide bubble when in menu #5529
Conversation
max-nextcloud
force-pushed
the
fix/hide-bubble-when-in-menu
branch
2 times, most recently
from
43aedac
to
6fe12c9
Compare
There was a problem hiding this comment.
Really nice work 🤩
I went through all the commits and think I followed most of the code changes. Lots of nice refactoring and cleanups in there!
I also did some manual testing around the link bubble and everything seems work reliable there. Just one nitpicking comment.
|
Not sure whether the failing Cypress test "Link website with selection" from |
It probably is. I think the link happens in the I'm tending to make the selection handling more inclusive - that is also show the link bubble when the cursor is in front of the link or behind the link as these cursor positions can be reached by clicking the link. |
max-nextcloud
force-pushed
the
fix/hide-bubble-when-in-menu
branch
from
d068db7
to
dcb7dc6
Compare
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
It is a prosemirror plugin view. No need for it to know tiptap data structures Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Also rename `clicked` state to `active`. We will also use it for activating via keypress Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
In appendTransation callbacks there is no view available. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
The `handleKeyDown` prop does not work in read only mode. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
The link bubble now also gets rendered when the cursor is behind the link. `cy.get` will always start at the root of the doc. So it also found the link inside the link bubble. Use `.find` on the content instead as the link bubble is outside of that. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/hide-bubble-when-in-menu
branch
from
dcb7dc6
to
fb0a8ce
Compare
📝 Summary
See: Link preview follow up #5442
Move the event handling into the LinkBubble plugin and expose a command to hide the link bubble.
Make use of that command to hide the link bubble when opening the preview menu.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)