-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add primary attribute for current user #2878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach looks good.
ESLint has some complains as can be seen in the Files changed tab.
Other than that seems good to go.
vinicius73
reviewed
Sep 9, 2022
luka-nextcloud
force-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
September 12, 2022 17:00
1236681
to
a1d9461
Compare
@max-nextcloud @vinicius73 Please check again. |
vinicius73
approved these changes
Sep 12, 2022
/rebase |
Signed-off-by: Luka Trovic <[email protected]>
nextcloud-command
force-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
September 13, 2022 07:29
a1d9461
to
640a1e1
Compare
/compile |
mejo-
force-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
September 13, 2022 07:58
6a6c456
to
1b1b77a
Compare
I added a commit to fix the (unrelated) eslint warning introduced by #2867. |
Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
September 13, 2022 08:01
1b1b77a
to
18a0598
Compare
/compile amend |
Signed-off-by: nextcloud-command <[email protected]> Signed-off-by: Jonas <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
September 13, 2022 08:05
18a0598
to
7f883b1
Compare
mejo-
approved these changes
Sep 13, 2022
delete-merged-branch
bot
deleted the
bug/use-primary-attr-for-current-user-mention
branch
September 13, 2022 08:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic [email protected]
Summary