-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user mentions feature #2748
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
From a user perspective: If this is about the markdown file, I would expect everything I type to be saved in the markdown file. @John volunteered to take the night shift Or maybe with linking like [@John](/u/johns_username) volunteered to take the night shift |
Yes, it should be put into the file. As mentioned we need to store the user id, but would also want the user display name as a readable representation so I tend to use the format that https://github.com/quartzy/markdown-it-mentions#quartzymarkdown-it-mentions parses already: Notifications would be a second step then, which we could however handle in the backend when the file is actually saved. |
Regarding the UI, we should stick to how Talk and comments do it. See https://nextcloud-vue-components.netlify.app/#/Components/RichContenteditable for a reference on the UI, we cannot reuse that component however. |
3ca8901
to
38fbcb4
Compare
403c2fa
to
72c98c5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice on the UI already, I've left some comments inline.
As a next step we may want to discuss how we issue notifications to the mentioned users. I'd say the best might be to do this on the save of the document (which might be a bit delayed), but then we can easily parse the full content and ensure that only notifications which are present are still active. |
@luka-nextcloud Pushed a few commits split by what they do when working on using the vue component for rendering. Let's move this to a mergeable state tomorrow. Missing points would be: Moved to top post. |
@juliushaertl With the integration of the |
274d7e2
to
de15d50
Compare
96267e5
to
df46dcc
Compare
df46dcc
to
7992e5d
Compare
Signed-off-by: Luka Trovic <[email protected]>
Signed-off-by: Luka Trovic <[email protected]>
Signed-off-by: Luka Trovic <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Luka Trovic <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
7992e5d
to
768208d
Compare
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
whoohoo... so cool this landed! |
Signed-off-by: Luka Trovic [email protected]
Summary
It should be possible to mention users.
ToDo
Follow up tickets
Dependencies added (in case needed during rebase):