Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Vue 2.7 #2685

Merged
merged 9 commits into from
Jul 22, 2022
Merged

Update to Vue 2.7 #2685

merged 9 commits into from
Jul 22, 2022

Conversation

vinicius73
Copy link
Member

@vinicius73 vinicius73 commented Jul 6, 2022 •
edited
Loading

@vinicius73 vinicius73 added enhancement New feature or request dependencies Pull requests that update a dependency file 2. developing dependencies: javascript labels Jul 6, 2022
@vinicius73 vinicius73 self-assigned this Jul 6, 2022
@vinicius73 vinicius73 requested review from max-nextcloud and mejo- July 6, 2022 23:39
@max-nextcloud
Copy link
Collaborator

Thanks a lot for looking into this 😍

@vinicius73 vinicius73 force-pushed the feature/update-vue-2-7 branch from 07647f2 to f14b4e6 Compare July 8, 2022 20:03
@vinicius73
Copy link
Member Author

/rebase

@vinicius73
Copy link
Member Author

Still not working
I've opened an issue in Vue v2 repo

vuejs/vue#12667

@vinicius73 vinicius73 force-pushed the feature/update-vue-2-7 branch from 888f3bd to cc756c4 Compare July 19, 2022 13:44
@vinicius73 vinicius73 marked this pull request as ready for review July 19, 2022 13:53
@juliusknorr
Copy link
Member

🥳

juliusknorr
juliusknorr reviewed Jul 19, 2022
View reviewed changes
css/prosemirror.scss Outdated Show resolved Hide resolved
@vinicius73
Copy link
Member Author

It is working now 🎉

@vinicius73 vinicius73 force-pushed the feature/update-vue-2-7 branch from cc756c4 to 71d6230 Compare July 22, 2022 11:47
Vinicius Reis added 6 commits July 22, 2022 08:57
⬆️ Upgrade dependencies
505b243 
- removes jest-raw-loader
- add vue-demi

Signed-off-by: Vinicius Reis <[email protected]>
✅ fix skiped tests
0076c79 
Signed-off-by: Vinicius Reis <[email protected]>
🚨 fix build warnings
3120d0b 
::v-deep usage as a combinator has been deprecated

Signed-off-by: Vinicius Reis <[email protected]>
🚨 fix lint warnings
0774f56 
Signed-off-by: Vinicius Reis <[email protected]>
⬆️ Upgrade dependencies.
048a94b 
Signed-off-by: Vinicius Reis <[email protected]>
⏪️ revert unrelated change
1032644 
Signed-off-by: Vinicius Reis <[email protected]>
@vinicius73 vinicius73 force-pushed the feature/update-vue-2-7 branch from 88e3881 to 1032644 Compare July 22, 2022 12:01
@vinicius73 vinicius73 mentioned this pull request Jul 22, 2022
Closed
@juliusknorr
Copy link
Member

/compile

@juliusknorr
Copy link
Member

Vue packages version mismatch:

  • [email protected] (/home/runner/work/text/text/node_modules/vue/dist/vue.runtime.common.js)
  • [email protected] (/home/runner/work/text/text/node_modules/vue-template-compiler/package.json)

➕ prevent version mismatch
2fb781e 
Signed-off-by: Vinicius Reis <[email protected]>
@vinicius73 vinicius73 force-pushed the feature/update-vue-2-7 branch from 6e4634a to 2fb781e Compare July 22, 2022 13:29
@marcelklehr
Copy link
Member

Vue packages version mismatch

The migration docs say template compiler isn't necessary anymore as a separate dependency in v2.7, I think

@vinicius73
Copy link
Member Author

The migration docs say template compiler isn't necessary anymore as a separate dependency in v2.7, I think

Yes, it is true.

But I guess we must fix it on https://github.com/nextcloud/webpack-vue-config/blob/b3100850cc78c51fa6258d53b2116484f7fff64d/package.json#L38

@vinicius73
Copy link
Member Author

/compile

marcelklehr
marcelklehr reviewed Jul 22, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@marcelklehr
Copy link
Member

Note: if you are using @vue/test-utils, you may need to keep it in the dependencies for now, but this requirement will also be lifted in a new release of test utils.

Ah, when using test-utils it might still be needed

@vinicius73 vinicius73 force-pushed the feature/update-vue-2-7 branch from 9d3281d to 3e1b3ee Compare July 22, 2022 13:54
@vinicius73
Copy link
Member Author

/compile

@nextcloud-command
Compile assets
3a75a48 
Signed-off-by: nextcloud-command <[email protected]>
@vinicius73 vinicius73 merged commit 958f41c into master Jul 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/update-vue-2-7 branch July 22, 2022 14:27
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@marcelklehr marcelklehr marcelklehr approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@mejo- mejo- Awaiting requested review from mejo-

Assignees

@vinicius73 vinicius73

Labels
2. developing dependencies: javascript dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vinicius73 @max-nextcloud @juliusknorr @marcelklehr @nextcloud-command