-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rich workspaces overlap with new file dropdown #1574
Conversation
a70b2d9
to
68d40c3
Compare
11386e5
to
966f4ee
Compare
Rebased |
@juliushaertl Could you take a look when you have time? Thanks. |
/rebase |
/compile amend / |
@@ -638,7 +638,7 @@ export default { | |||
#editor { | |||
overflow: auto; | |||
// Fix for IE11 issue where the menubar sometimes was positioned under the text | |||
z-index: 1000; | |||
z-index: 20; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind to drop the comment above since with the removed IE11 support this is no longer required and caused side effects the bug the pr fixes ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Sorry for taking so long for the review, I have a small comment, but tested and works fine otherwise 👍 |
I wonder what the difference to this PR is: #1631 |
The https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Positioning/Understanding_z_index/Stacking_without_z-index and The second PR would be a good possible addition to avoid further overlay issues, but I need to do some further testing on that. |
Signed-off-by: Gary Kim <[email protected]>
966f4ee
to
805d691
Compare
/backport to stable22 |
The backport to stable22 failed. Please do this backport manually. |
Created the backport manually in #1769 |
/backport to stable21 |
The backport to stable21 failed. Please do this backport manually. |
Created the backport manually in #1770 |
Fix https://github.com/nextcloud/server/issues/27588
Before
After