Inserting image into line of text will add line break two chars after

[max-nextcloud]

This is a follow up to #3282.

We currently the cursor two steps further after inserting the image and before inserting the hard break (if the image is not inserted as first element, which needs other special treatment). This is necessary because per default the cursor is in front of the image after inserting it, but we want to add the hard break afterwards.

If you insert an image in between text, this results in the linebreak being inserted two characters further for the moment. I think that's an acceptable tradeoff given that images are block nodes now and most likely it will not happen that often that people insert them in the middle of text anyway.

Here's the relevant code:

text/src/components/Editor/MediaHandler.vue

Lines 199 to 209 in 02dc2ba

	const selection = this.$editor.view.state.selection
	if (!selection.empty) {
	// If inserted image is first element, it is selected and would get overwritten by
	// subsequent editor inserts (see tiptap#3355). So unselect the image by placing
	// the cursor at the end of the selection.
	this.$editor.commands.focus(selection.to)
	} else {
	// Place the cursor after the inserted image node
	this.$editor.commands.focus(selection.to + 2)
	}

If you have a quick idea how to detect that the cursor (i.e. the focus, this.$editor.view.state.selection) is in the middle of some text and not at the end of a paragraph, we could add this as another special handling. But instead of waiting longer and spending another bunch of hours on this minor issue, my suggestion would be to merge this PR as is now 😉

Originally posted by @mejo- in #3282 (comment)

[max-nextcloud]

https://github.com/nextcloud/text/tree/fix/gapcursor

[max-nextcloud]

This is still an issue. We should really use gapcursor instead of adding empty lines.