Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migare reuse to toml format and generate license files #977

Merged
merged 8 commits into from
Sep 9, 2024
Merged

Migare reuse to toml format and generate license files #977

merged 8 commits into from
Sep 9, 2024

Conversation

AndyScherzinger
Copy link
Member

No description provided.

@AndyScherzinger
Copy link
Member Author

/compile /

nextcloud-command and others added 3 commits September 9, 2024 07:52
@nextcloud-command
chore(assets): Recompile assets
1d09b86 
Signed-off-by: nextcloud-command <[email protected]>
@AndyScherzinger
fix: use a precise license identifier
f3a3598 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
fix: Add missing license files
49c11ae 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
Copy link
Member Author

/compile /

@nextcloud-command
chore(assets): Recompile assets
7438258 
Signed-off-by: nextcloud-command <[email protected]>
@AndyScherzinger
Copy link
Member Author

/compile /

@max-nextcloud
Copy link
Collaborator

https://github.com/nextcloud/terms_of_service/actions/runs/10770451329/job/29863856800
Bildschirmfoto vom 2024-09-09 14-54-24
compile failing.

max-nextcloud
max-nextcloud reviewed Sep 9, 2024
View reviewed changes
webpack.js Outdated Show resolved Hide resolved
webpack.js Outdated Show resolved Hide resolved
@AndyScherzinger
Copy link
Member Author

@max-nextcloud yeah, I've seen it, yet lack the understanding what is missing (or if a dependency might be too old)

@AndyScherzinger
Copy link
Member Author

let me try your suggestions👍

@AndyScherzinger
Copy link
Member Author

/compile /

@nextcloud-command
chore(assets): Recompile assets
3069ead 
Signed-off-by: nextcloud-command <[email protected]>
@AndyScherzinger
Copy link
Member Author

Thanks for the help @max-nextcloud
All issues should be fixed now and all checks and compile be green 💚

@max-nextcloud max-nextcloud merged commit bc7d563 into master Sep 9, 2024
24 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/noid/reuseToml branch September 9, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@GretaD GretaD Awaiting requested review from GretaD

Assignees
No one assigned
Labels
3. to review technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndyScherzinger @max-nextcloud @nextcloud-command