Don't provide username null #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1576 +/- ##
=======================================
Coverage 32.29% 32.29%
=======================================
Files 55 55
Lines 2799 2799
Branches 528 528
=======================================
Hits 904 904
Misses 1756 1756
Partials 139 139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix username is null error in the Avatar component nextcloud-libraries/nextcloud-vue#1856
Turns out I was using it wrong. When no user was found (yet), I set
displayNametonullwhile theAvatarcomponent assumesundefined.