Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1530/share android screen #1562

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Aug 31, 2021

this is just a proof of concept for #1530 to show that sharing the Android Screen is possible.

Please note that this is very quick and dirty and breaks other features atm!!!
basically video from camera was replaced by screen stream, so to test just make a videocall..

Work on screen sharing is paused indefinitely

mahibi added 3 commits August 31, 2021 10:25
note that this is very dirty and will break many things! basically video from camera was replaced by screen stream

Signed-off-by: Marcel Hibbe <[email protected]>
note that this is very dirty and will break many things! basically video from camera was replaced by screen stream

Signed-off-by: Marcel Hibbe <[email protected]>
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/1562-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi mentioned this pull request Aug 31, 2021
2 tasks
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings269271
Errors33

SpotBugs (new)

Warning Type Number
Bad practice Warnings 12
Correctness Warnings 140
Experimental Warnings 2
Internationalization Warnings 9
Malicious code vulnerability Warnings 168
Performance Warnings 40
Security Warnings 4
Dodgy code Warnings 227
Total 602

SpotBugs (master)

Warning Type Number
Bad practice Warnings 12
Correctness Warnings 139
Experimental Warnings 2
Internationalization Warnings 9
Malicious code vulnerability Warnings 168
Performance Warnings 39
Security Warnings 4
Dodgy code Warnings 227
Total 600

Lint increased!

SpotBugs increased!

@abdusalamApps
Copy link

Is there any new work being done here?

@mahibi
Copy link
Collaborator Author

mahibi commented Apr 17, 2023

Is there any new work being done here?

No new work was done here but it's a feature that might be added to the roadmap for the next versions

@abdusalamApps
Copy link

abdusalamApps commented Apr 21, 2023

Is there any new work being done here?

No new work was done here but it's a feature that might be added to the roadmap for the next versions

Thanks for the reply.
I would be more than glad to help with implementing it. I actually I tried, but I didn't know where to start! Any ideas or tips?

@mahibi
Copy link
Collaborator Author

mahibi commented Apr 21, 2023

Is there any new work being done here?

No new work was done here but it's a feature that might be added to the roadmap for the next versions

Thanks for the reply. I would be more than glad to help with implementing it. I actually I tried, but I didn't know where to start! Any ideas or tips?

thank you for the offer to help 👍
For lack of time i can't provide more specific instructions than having a look at this PR, sorry.
UI-wise i would begin with adding an option to the "more options" button.

@abdusalamApps
Copy link

Is there any new work being done here?

No new work was done here but it's a feature that might be added to the roadmap for the next versions

Thanks for the reply. I would be more than glad to help with implementing it. I actually I tried, but I didn't know where to start! Any ideas or tips?

thank you for the offer to help +1 For lack of time i can't provide more specific instructions than having a look at this PR, sorry. UI-wise i would begin with adding an option to the "more options" button.

My pleasure. I'll see what I can do, but I'll create a new branch from latest master, because I noticed that the code has changed considerably since this PR was created. So it would a clean start.

@GVLLIFESTYLE
Copy link

I would really be happy if this feature would not be set to ice.
Goto Webinar, Goto Meeting, Teams,... many more already support screenshare.
I wanna use my phone for presentations in Samsung Dex and with this feature I could replace my presentation pc.

1 similar comment
@GVLLIFESTYLE
Copy link

I would really be happy if this feature would not be set to ice.
Goto Webinar, Goto Meeting, Teams,... many more already support screenshare.
I wanna use my phone for presentations in Samsung Dex and with this feature I could replace my presentation pc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants