Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix console warnings and errors #1328

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Fix console warnings and errors #1328

merged 3 commits into from
Aug 30, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 29, 2024 •
edited
Loading

Some small fixes I had included in another branch but are easier to get in separately, mostly found in sentry as reported through the js console:

  • fix: Add aria-label to pagination
  • fix: Fix missing actions for empty default slot
  • fix: Proper evaluation order when building errors strings

@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Aug 29, 2024
@juliusknorr juliusknorr changed the title fix/small Fix console warnings and errors reported in sentry Aug 29, 2024
@juliusknorr juliusknorr changed the title Fix console warnings and errors reported in sentry Fix console warnings and errors Aug 29, 2024
@juliusknorr juliusknorr mentioned this pull request Aug 29, 2024
Open
3 tasks
enjeck
enjeck approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@juliusknorr juliusknorr merged commit ee0ffa4 into main Aug 30, 2024
47 checks passed
@juliusknorr juliusknorr deleted the fix/small branch August 30, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enjeck enjeck enjeck approved these changes

@grnd-alt grnd-alt Awaiting requested review from grnd-alt

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusknorr @enjeck