Fix adding the same participant several times in a row #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a participant is selected in the select2 dropdown the "change" event is triggered for the "Add participants" input; this sets the value of the input and also adds the participant to the room. However, the event is triggered only if the selected item is different than the current value of the "Add participant" input. Due to this, the value has to be cleared when it is set to make possible to add the same participant several times in a row (for example, in different rooms). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
backport-request
bug
feature: frontend 🖌️
Ivansss
approved these changes
Jun 6, 2018
Ivansss
deleted the
fix-adding-the-same-participant-several-times-in-a-row
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test (a):
How to test (b):
Expected result:
The user is added.
Actual result:
The user is not added.