Fix local audio and video not disabled when not available #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the streams are initialized and there is no audio or no video the "audio/videoNotFound" flag is set. This flag prevents the audio or video from being enabled later, and it is also used to discard calls to "disableAudio/Video", as there would be no need to disable them if they were not found. However, in that last case, it is necessary to explicitly disable them before the flag is set. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
backport-request
bug
feature: frontend 🖌️
Ivansss
approved these changes
Jun 6, 2018
Ivansss
deleted the
fix-local-audio-and-video-not-disabled-when-not-available
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the streams are initialized and there is no audio or no video the
audio/videoNotFoundflag is set. This flag prevents the audio or video from being enabled later, and it is also used to discard calls todisableAudio/Video, as there would be no need to disable them if they were not found. However, in that last case, it is necessary to explicitly disable them before the flag is set.The most evident problem of not disabling the video before setting
videoNotFoundcan be seen when joining a call with microphone but without camera, as in that case an empty video would be shown instead of the avatar of the local user.Before:
After:
