Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local video shadow #702

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Fix local video shadow #702

merged 1 commit into from
Mar 14, 2018

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Mar 12, 2018 •
edited
Loading

Fix #701

Before:

screen shot 2018-03-12 at 18 59 02

After:

screen shot 2018-03-12 at 18 59 32

@Ivansss Ivansss added this to the 3.2 (Nextcloud 13.0.2) milestone Mar 12, 2018
@Ivansss Ivansss changed the title Set overflow visible for local video. Fix local video shadow Mar 12, 2018
@nickvergessen
Copy link
Member

Works for me with and without the patch,
which browser was broken?

@Ivansss
Copy link
Member Author

Ivansss commented Mar 14, 2018

Try reducing browser's window size. I can reproduce it with chrome and firefox.

@nickvergessen
Copy link
Member

ah, okay, small window is the issue.

@nickvergessen nickvergessen merged commit b3f16dc into master Mar 14, 2018
@nickvergessen nickvergessen deleted the bugfix/701/missing-shadow-local-video branch March 14, 2018 13:50
@jancborchardt
Copy link
Member

@Ivansss nice! :)

@Ivansss Ivansss mentioned this pull request Mar 19, 2018
Merged
@nickvergessen nickvergessen mentioned this pull request Mar 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
3. to review bug design
Projects
None yet
Milestone
3.2 (Nextcloud 13.0.2)
Development

Successfully merging this pull request may close these issues.
3 participants
@Ivansss @nickvergessen @jancborchardt