Feature/noid/more remote testing #6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
nickvergessen
force-pushed
the
feature/noid/more-remote-testing
branch
3 times, most recently
from
ed2636b
to
29775ef
Compare
|
Still not fully done, but another step taken and since it changes non-testing files I'd like to merge it to avoid future conflicts |
danxuliu
reviewed
Feb 11, 2022
There was a problem hiding this comment.
Code looks good 👍
But... I would like to remove the integration test from the second commit, as it does not work and I found it misleading when doing the review, and move the third commit to the end, as it depends on its following commits to work. Yes, you hate me, I know :-P
| @@ -18,7 +24,13 @@ ${ROOT_DIR}/occ app:enable spreed || exit 1 | |||
| ${ROOT_DIR}/occ app:enable spreedcheats || exit 1 | |||
| ${ROOT_DIR}/occ app:list | grep spreed | |||
|
|
|||
| # Disable bruteforce protection because the integration tests do trigger them | |||
| ${ROOT_DIR}/occ config:system:set auth.bruteforce.protection.enabled --value false --type bool | |||
There was a problem hiding this comment.
Is this needed in Talk tests too?
There was a problem hiding this comment.
Soon there will be bruteforce protection being added to the endpoint, yes.
nickvergessen
force-pushed
the
feature/noid/more-remote-testing
branch
from
29775ef
to
d8845a0
Compare
danxuliu
approved these changes
Feb 16, 2022
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
feature/noid/more-remote-testing
branch
from
d8845a0
to
c9422ac
Compare
|
Drone conflict after #6730 Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.