-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Recieving Room Shares #5775
Conversation
783095b
to
0cb0c07
Compare
What is From my POV they could be part of existing tables? An incoming federation creates a room in the room table with token and the new field federation-server. Afterwards the individual users get their own records in the attendees table again. this means the existing database queries are enough and we don't add another one when getting the users rooms or the participants in a room |
Outgoing federation sounds good. Incoming federations in the room table might be problematic since each new user is given a separate secret. Would it be okay to have a room per user? So if 4 users on a local server is participating in a federated room hosted on another server, it's handled as if it is 4 rooms on the local server. We could also handle it such that each room from a remote server is a single room on the local server then the attendees table is used to keep track of the number of the token for each user that is in the room. That'd mean two new actor types, one for federated (users on another server) and one for shared (users on the local server that have gotten an incoming share). |
cb64a33
to
7069c9e
Compare
286ef27
to
a44c90b
Compare
f9d38a1
to
c7ba09b
Compare
1f3b6b2
to
994f629
Compare
What was the plan with integration tests? Same PR or follow up? |
This is purely receiving so it's a bit difficult to do integration tests at the moment. It's part of the share sending PR though, no worries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
31f4942
to
0320cf1
Compare
0320cf1
to
9ffc8e6
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Gary Kim <[email protected]>
Signed-off-by: Gary Kim <[email protected]>
Signed-off-by: Gary Kim <[email protected]>
Signed-off-by: Gary Kim <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
cb095fb
to
06dd757
Compare
Rebased to resolve conflict |
For #5723
Also have a version that avoids adding and extra table here: https://github.com/nextcloud/spreed/tree/enh/5723%2Fadd-database-single