Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presentation support #387

Closed
wants to merge 65 commits into from
Closed

Presentation support #387

wants to merge 65 commits into from

Conversation

leonklingele-work
Copy link

@leonklingele-work leonklingele-work commented Aug 25, 2017

Missing

  • Support for multiple presentations
  • Presentation control panel (switch between presentations)
  • Presentation control panel (page number selection)
  • ODF presentation support We no longer want this for the first version
  • Resume support, i.e. loading the presentation for new participants which joined after the P was uploaded TODO: Sometimes it doesn't work, likely the case when the peer connection is not ready yet (?)
  • Fix styling issues
  • Load Ps inside Iframe as a security precaution

Testing the PR

@leonklingele-work
Copy link
Author

This adds support for #32

@codecov
Copy link

codecov bot commented Aug 25, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@7d8b5f0). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #387   +/-   ##
========================================
  Coverage          ?   10.1%           
  Complexity        ?     421           
========================================
  Files             ?      26           
  Lines             ?    1999           
  Branches          ?       0           
========================================
  Hits              ?     202           
  Misses            ?    1797           
  Partials          ?       0
Impacted Files Coverage Δ Complexity Δ
appinfo/routes.php 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8b5f0...e960e48. Read the comment docs.

@nickvergessen
Copy link
Member

I get the following error when clicking on the "upload" button.

Uncaught TypeError: propertyName.match is not a function
    at dav.Client.parseClarkNotation (client.js:442)
    at dav.Client.propFind (client.js:74)
    at Client.getFolderContents (client.js:436)
    at Object._fillFilePicker (oc-dialogs.js:790)
    at HTMLDocument.<anonymous> (oc-dialogs.js:217)
    at j (jquery.js:3099)
    at Object.add [as done] (jquery.js:3145)
    at a.fn.init.n.fn.ready (jquery.js:3378)
    at Object.<anonymous> (oc-dialogs.js:210)
    at Object.<anonymous> (jquery.js:3256)

Another thing: can you not commit the 3rdparty stuff and instead have it done via make?
Like a lot other apps already do it. This would keep the PR and code a bit more maintainable.

@leonklingele-work
Copy link
Author

I get the following error when clicking on the "upload" button.

Sorry, I forgot to mention you need to apply this patch: owncloud/davclient.js#31

can you not commit the 3rdparty stuff and instead have it done via make

Other 3rd party stuff is currently included as well, see https://github.com/nextcloud/spreed/tree/master/js/vendor

@nickvergessen nickvergessen changed the title WIP:Presentation support Presentation support Sep 12, 2017
@nickvergessen nickvergessen added this to the 3.1 (Nextcloud 13.0.2/3) milestone Nov 14, 2017
@nickvergessen nickvergessen changed the base branch from master to stable13 January 15, 2018 13:49
@nickvergessen nickvergessen changed the base branch from stable13 to master March 9, 2018 15:08
@nickvergessen nickvergessen modified the milestones: 3.2 (Nextcloud 13.0.2), 4.0 (Nextcloud 14) Mar 9, 2018
@nickvergessen nickvergessen added feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients and removed feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients feature: screensharing labels Mar 23, 2018
@nickvergessen
Copy link
Member

Due to the many conflicts and the stale progress im closing this.

@nickvergessen nickvergessen deleted the presentation-support branch July 26, 2018 08:53
marcoambrosini pushed a commit that referenced this pull request Oct 9, 2019
Allow to disable a popover menu button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing enhancement feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants