Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datachannels #335

Merged
merged 2 commits into from
Jun 7, 2017
Merged

Fix datachannels #335

merged 2 commits into from
Jun 7, 2017

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Jun 6, 2017

  • Re-send messages that could not be sent because datachannel was still not opened.
  • Do not create multiple datachannels. Send all messages through 'status' datachannel.

@codecov
Copy link

codecov bot commented Jun 6, 2017

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #335   +/-   ##
=========================================
  Coverage     15.62%   15.62%           
  Complexity      274      274           
=========================================
  Files            18       18           
  Lines          1293     1293           
=========================================
  Hits            202      202           
  Misses         1091     1091

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 398efaa...e0819b0. Read the comment docs.

@nickvergessen
Copy link
Member

What issues does this help with?

@Ivansss
Copy link
Member Author

Ivansss commented Jun 7, 2017

Sometimes some channeling messages were not send because the data channel was still not opened and there was not handler for that situation.

For example here 'videoOn' message was not sent so avatar is still visible.
screen shot 2017-06-07 at 11 18 44

@Ivansss Ivansss merged commit d93e8aa into master Jun 7, 2017
@Ivansss Ivansss deleted the fix-datachannels branch June 7, 2017 10:12
marcoambrosini pushed a commit that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants