Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow logged in users to join public rooms again #296

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Allow logged in users to join public rooms again #296

merged 1 commit into from
Apr 21, 2017

Conversation

nickvergessen
Copy link
Member

@Ivansss as discussed

@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants labels Apr 21, 2017
@nickvergessen nickvergessen added this to the 1.3 milestone Apr 21, 2017
@codecov
Copy link

codecov bot commented Apr 21, 2017 •
edited
Loading

Codecov Report

Merging #296 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #296      +/-   ##
============================================
- Coverage     15.79%   15.72%   -0.08%     
- Complexity      266      269       +3     
============================================
  Files            17       17              
  Lines          1266     1272       +6     
============================================
  Hits            200      200              
- Misses         1066     1072       +6
Impacted Files Coverage Δ Complexity Δ
lib/Manager.php 0% <0%> (ø) 39 <0> (+1) ⬆️
lib/Controller/ApiController.php 0% <0%> (ø) 72 <0> (ø) ⬇️
lib/Room.php 0% <0%> (ø) 32 <1> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfdae84...04ee525. Read the comment docs.

Ivansss
Ivansss approved these changes Apr 21, 2017
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ivansss Ivansss merged commit 8632827 into master Apr 21, 2017
@Ivansss Ivansss deleted the public-rooms-for-logged-in-users branch April 21, 2017 13:23
marcoambrosini pushed a commit that referenced this pull request Oct 9, 2019
@skjnldsv
Merge pull request #296 from nextcloud/fix-app-nav-prop
3f62074 
remove obsolete prop 'navigationClass'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansss Ivansss Ivansss approved these changes

Assignees
No one assigned
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @Ivansss