[stable16] Fix peer creation for participants no longer in the call #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
When the current participant lefts a call WebRTC is not properly tore down; signaling events are still handled, so if an offer message is received after leaving a call (which in general should not happen, but in some strange cases it could) a new Peer object was created. Although the proper fix would be to disconnect WebRTC and the signaling events after leaving a call that would require deeper changes, so for now offers received when not in a call are ignored. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
When a participant is not in the call a Peer object should not be created for her; besides being incorrect, that would also create a VideoView for that participant, which will basically stay there as a ghost without never connecting to her. Due to this when a participant leaves the call the delayed peer creation for that participant, if any, has to be cancelled; otherwise once the timeout expires the peer would be created with the issue just described. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
backportbot-nextcloud
bot
added
bug
feature: frontend 🖌️
backportbot-nextcloud
bot
requested review from
danxuliu,
Ivansss and
nickvergessen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2004