Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to escape commands #1919

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Allow to escape commands #1919

merged 2 commits into from
Jul 3, 2019

Conversation

nickvergessen
Copy link
Member

Fix #1841

@nickvergessen
Allow to escape commands
2b0539e 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added 3. to review enhancement feature: chat 💬 Chat and system messages feature: bots 🤖 /commands in chat messages labels Jun 25, 2019
@nickvergessen nickvergessen added this to the 💚 Next Major milestone Jun 25, 2019
@danxuliu
Add integration test for escaped commands
7a605e5 
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
danxuliu approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@nickvergessen nickvergessen merged commit 3a78f64 into master Jul 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/1841/allow-to-escapce-commands branch July 3, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
4. to release enhancement feature: bots 🤖 /commands in chat messages feature: chat 💬 Chat and system messages
Projects
None yet
Milestone
7.0.0-beta1
Development

Successfully merging this pull request may close these issues.

Escape a command
3 participants
@nickvergessen @skjnldsv @danxuliu