[stable16] Fix messages not loaded when commands are used with the MCU #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
When fetching chat messages ChatController may not return as many messages as requested. In the past this meant that there were no more messages in the room, but since the introduction of commands some messages may not be returned because they should not be visible to the participant fetching them. Thus, now the number of returned messages does not mean anything regarding whether there are still more messages in the room or not, but this can be known by looking for a "304 Not modified" response (which is only sent when there are no more messages in the room). When no MUC is used the chat messages are polled again and again, so the behaviour change explained above made no difference. However, when the MCU is used the messages are fetched until there are no more messages in the room and, then, they are only fetched when a new message is sent. Checking whether there are more messages in the room or not was based on the number of returned messages, so the fetch of messages until there were no more messages in the room wrongly stopped when fetching a batch of messages that included one not visible for the current participant. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
backportbot-nextcloud
bot
added
bug
feature: frontend 🖌️
nickvergessen
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1801