Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning with many users without external signaling #1649

Conversation

nickvergessen
Copy link
Member

Fix #337

Warning when starting/joining the call

external-signaling-warning2

Admin settings

external-signaling-warning

@nickvergessen nickvergessen added 2. developing bug feature: settings ⚙️ Settings and config related issues feature: signaling 📶 Internal and external signaling backends feature: frontend 🖌️ "Web UI" client labels Mar 21, 2019
@nickvergessen nickvergessen added this to the 💚 Next Major milestone Mar 21, 2019
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to respect hideWarning setting.

Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the bugfix/337/show-a-warning-with-many-users-without-external-signaling branch from 2c45daa to eda586c Compare March 21, 2019 15:29
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@nickvergessen nickvergessen merged commit d25564b into master Mar 21, 2019
@nickvergessen nickvergessen deleted the bugfix/337/show-a-warning-with-many-users-without-external-signaling branch March 21, 2019 16:50
This was referenced Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: frontend 🖌️ "Web UI" client feature: settings ⚙️ Settings and config related issues feature: signaling 📶 Internal and external signaling backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants