Fix display name of reshare with one-to-one room not invited to #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The display name of reshares with one-to-one rooms not invited to was always set to the display name of the last participant. Now it includes the name of both participants in the room instead. Note that this is not needed for deleted shares, as in that case only shares by the user, not reshares, need to be formatted. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: upload & shares & voice 📤🎙️
|
/backport to stable15 |
nickvergessen
approved these changes
Jan 8, 2019
I thought the same, but the leaking is consistent with the behaviour of other shares; for example, when a share is reshared with a group, the name of the group can be seen too by the owner of the share even if she is not in that group. |
True, but there is a difference, you can share to that group yourself, while you can not share to rooms you are not a member off |
nickvergessen
approved these changes
Jan 30, 2019
nickvergessen
deleted the
fix-display-name-of-reshare-with-one-to-one-room-not-invited-to
branch
|
backport to stable15 in #1495 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The display name of reshares with one-to-one rooms not invited to was always set to the display name of the last participant. However, this happens since 4afa2d7; before that the first participant was always used. Now the name of both participants in the room is used instead, which also fixes the integration tests that were broken in 4afa2d7.