Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: invite email guests when creating a conversation #13699

Merged
merged 3 commits into from
Nov 6, 2024
Merged

feat: invite email guests when creating a conversation #13699

merged 3 commits into from
Nov 6, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 5, 2024 •
edited
Loading

☑️ Resolves

  • Fix Invite emails directly when creating a conversation #4937
  • As for now participants added after conversation is created and token is known, that works the same way as adding participant from the right sidebar
  • If at least one participant is e-mail, create a public conversation instead of rewriting it later on backend
  • Also extract API call for 'core/autocomplete/get' to not mix with conversation services

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Nov 5, 2024
@Antreesy Antreesy self-assigned this Nov 5, 2024
@Antreesy Antreesy changed the title fix: move autocompleteQuery to coreService feat: invite email guests when creating a conversation Nov 5, 2024
@nickvergessen
Copy link
Member

If at least one participant is e-mail, create a public conversation instead of rewriting it later on backend

I would not do that, so once #13609 works we don't have clients that create "wrong" conversations by default

@Antreesy Antreesy force-pushed the fix/4937/invite-emails-to-conversation branch from d595f91 to 00b98a1 Compare November 5, 2024 13:36
@Antreesy Antreesy force-pushed the fix/4937/invite-emails-to-conversation branch from 00b98a1 to a7d9eb9 Compare November 5, 2024 15:49
DorraJaouad
DorraJaouad approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

src/components/NewConversationDialog/NewConversationDialog.vue Outdated Show resolved Hide resolved
@Antreesy
fix: allow to add e-mail guests when creating a conversation
002c5a7 
- introduce 'forceTypes' in autocomplete request

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/4937/invite-emails-to-conversation branch from a7d9eb9 to 002c5a7 Compare November 6, 2024 10:04
@Antreesy
Copy link
Contributor Author

Antreesy commented Nov 6, 2024

/backport to stable30

@Antreesy Antreesy merged commit 9cb29bf into main Nov 6, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/4937/invite-emails-to-conversation branch November 6, 2024 10:06
@backportbot backportbot bot mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nickvergessen nickvergessen nickvergessen left review comments

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Invite emails directly when creating a conversation
3 participants
@Antreesy @nickvergessen @DorraJaouad