Fix the scroll position of the chat view in the sidebar #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calls to the default methods from the server to open and close the sidebar had to be replaced by their implementation to be able to also trigger an event when the animation ends. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Calling "restoreScrollPosition" twice caused the chat view to be scrolled to the top due to not taking into account the current scroll position. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
When the chat view was in the sidebar, the scroll position of the chat view was reset to the top every time that the sidebar was closed and opened again or the chat tab was selected after changing to a different one. The reason is that detaching an element and attaching it again, which happens in both scenarios, resets the scroll position of the element, so now the scroll position is explicitly saved before closing the sidebar or unselecting the chat tab and restored again after opening the sidebar or selecting the chat tab again. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
backport-request
bug
feature: chat 💬
Ivansss
approved these changes
Nov 19, 2018
Ivansss
deleted the
fix-the-scroll-position-of-the-chat-view-in-the-sidebar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the chat view was in the sidebar, the scroll position of the chat view was reset to the top every time that the sidebar was closed and opened again or the chat tab was selected after changing to a different one.
The reason is that detaching an element and attaching it again, which happens in both scenarios, resets the scroll position of the element, so now the scroll position is explicitly saved before closing the sidebar or unselecting the chat tab and restored again after opening the sidebar or selecting the chat tab again.
How to test (scenario 1):
How to test (scenario 2):
Expected result:
The scroll position of the list of messages is the same as before.
Actual result:
The list of messages is scrolled to the top.