Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix avatars in federated calls #12863

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Fix avatars in federated calls #12863

merged 3 commits into from
Aug 1, 2024

Commits on Aug 1, 2024

  1. fix: Provide actor type and id of participants in signaling messages 

    When the Nextcloud server notifies the signaling server about updates in
the participants it provides a list of properties about each participant
that will be relayed to the clients in the "participants->update"
signaling messages. When federated users were added to the participants
whose properties were relayed the "userId", which until then was set
only for regular users, was set too to the actor id for federated
participants. However, this approach was lacking, as it was not possible
for clients to really know from the "userId" property if the participant
was federated or not or, in a more general way, its actor type.

Due to that the "userId" is again set only for regular users for
backwards compatibility, and the "actorType" and "actorId" properties
are added to the data of each participant included in the
"participants->update" signaling message.

For consistency, "actorType" and "actorId" is also set in the equivalent
message of the internal signaling server.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    cc648fd View commit details
    Browse the repository at this point in the history

  2. fix: Handle actor type and id of participants in signaling messages 

    The actor type and id are now set in "CallParticipantModel" when a
participant joins the call, similarly to how it was done for the user
ID.

Actor type and id now take precedence over the user ID in the
"VideoView" component, so "AvatarWrapper" now uses the correct source
for participant avatars (as long as the actor type and id are correct,
which in federated conversations require a conversion from the values
sent by the host server and the values used by the federated server).

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    32ba79d View commit details
    Browse the repository at this point in the history

  3. chore: Update OpenAPI 

    Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0264d3d View commit details
    Browse the repository at this point in the history