Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(Quote): prevent button click event from propagation #12841

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 29, 2024

Backport of #12824

- button was wrapped in a <a> link, which was an a11y issue and false positive trigger when cancelling the reply
- for 'reply to message' variant wrap component in a simple div

Signed-off-by: Maksim Sukharev <[email protected]>

(cherry picked from commit 5a3d732)
Signed-off-by: Maksim Sukharev <[email protected]>
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy Antreesy marked this pull request as ready for review July 29, 2024 10:35
@Antreesy Antreesy enabled auto-merge July 29, 2024 10:35
@Antreesy Antreesy merged commit 66f82f8 into stable29 Jul 29, 2024
48 checks passed
@Antreesy Antreesy deleted the backport/12824/stable29 branch July 29, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant