chore(deps): replace vue-shortkey with vueuse directive #12698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
3. to review
technical debt
feature: frontend 🖌️
|
31 or backport? |
Planning to upstream to vue-lib |
- codestyle refactoring - replace if blocks with ternary operators - remove redundant method Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/noid/replace-vue-shortkey-directive
branch
from
6d7ede0
to
68c100c
Compare
Antreesy
commented
Aug 21, 2024
| @@ -246,6 +241,7 @@ export default { | |||
|
|
|||
| created() { | |||
| window.addEventListener('beforeunload', this.preventUnload) | |||
| useHotKey('f', this.handleAppSearch, { ctrl: true, stop: true, prevent: true }) | |||
There was a problem hiding this comment.
Doesn't work because event is captured by UnifiedSearch first (same on master, so not related to this PR):
There was a problem hiding this comment.
Works in the desktop client
- move push-to-talk feature to related component Signed-off-by: Maksim Sukharev <[email protected]>
- LeftSidebar searchbox - NewMessage input Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/noid/replace-vue-shortkey-directive
branch
from
68c100c
to
43fdc1b
Compare
ShGKme
approved these changes
Aug 21, 2024
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
vue-shortkeylibraryImportant
@keydownlistener from NcButton (it's same as click)🖌️ UI Checklist
🖼️ Screenshots / Screencasts
No visual or UX changes
🚧 Tasks
🏁 Checklist