Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to save the log of a chat #1256

Closed
wants to merge 9 commits into from
Closed

Option to save the log of a chat #1256

wants to merge 9 commits into from

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 15, 2018 •
edited
Loading

Example

15. Oktober 2018 um 13:37:29 GMT+0 @Heilbronner Falken: Hello @Bad Nauheim (1) and @Bad Tölz (2)
15. Oktober 2018 um 13:54:12 GMT+0 @Heilbronner Falken: multi
   line
   test
15. Oktober 2018 um 13:54:44 GMT+0 @Heilbronner Falken: test
15. Oktober 2018 um 14:03:14 GMT+0 im-a-guest-name (Gast): asdasd

Fix #232

@nickvergessen
Add a new column to save the last read message
a55173a 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add data migration step
31e82d1 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Use the last read message id
413d11c 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix writing of the last_*_message fields
13b92c7 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Also migrate the mention markers
2211a07 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Live migration for the read marker in case it failed on the update
d50de2b 
The current migration only works if the user read in the same exact second
as the comment was posted (author only). So we set the read marker to -1
for all users and in case of -1 we calculate the marker on the next request,
because it is not possible in a programmatic way with a reasonable O(1) or O(n)
but requires one query per user&chat.

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Expose the lastReadMessage in the API and use it for lookIntoTheFuture
0a0b8e0 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Option to save the log of a chat
e55e4f7 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added this to the 💚 Next Major milestone Oct 15, 2018
@nickvergessen nickvergessen added 2. developing enhancement feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Oct 15, 2018
@nickvergessen
Better date handling
d29f9f3 
Signed-off-by: Joas Schilling <[email protected]>
@jancborchardt
Copy link
Member

jancborchardt commented Dec 21, 2018 •
edited
Loading

@nickvergessen to reply to your question in the issue:

are you okay with putting it as an option into the "…" menuof the conversation list?

I’m not sure this function is really that widely useful. Copypaste generally works, and exporting is by far not as important as the other things in the 3-dot menu. If we start putting stuff like that in there, it will get worse. :\

I’d advise that we simply don’t have this. Unless we really get a lot of demand for it, which doesn’t seem to be the case right now.

@nickvergessen nickvergessen deleted the feature/noid/export branch February 12, 2019 10:49
This was referenced Apr 14, 2019
Closed
Closed
marcoambrosini pushed a commit that referenced this pull request Oct 9, 2019
@dependabot @skjnldsv
Bump eslint-plugin-import from 2.16.0 to 2.17.1 (#347)
1433210 
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.16.0 to 2.17.1.
<details>
<summary>Changelog</summary>

*Sourced from [eslint-plugin-import's changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md).*

> ## [2.17.1] - 2019-04-13
> 
> ### Fixed
> - require v2.4 of `eslint-module-utils` ([#1322])
> 
> ## [2.17.0] - 2019-04-13
> 
> ### Added
> - Autofixer for [`no-duplicates`] rule ([#1312], thanks [@&#8203;lydell])
> - [`no-useless-path-segments`]: Add `noUselessIndex` option ([#1290], thanks [@&#8203;timkraut])
> - [`no-duplicates`]: Add autofix ([#1312], thanks [@&#8203;lydell])
> - Add [`no-unused-modules`] rule ([#1142], thanks [@&#8203;rfermann])
> - support export type named exports from typescript ([#1304], thanks [@&#8203;bradennapier] and [@&#8203;schmod])
> 
> ### Fixed
> - [`order`]: Fix interpreting some external modules being interpreted as internal modules ([#793], [#794] thanks [@&#8203;ephys])
> - allow aliases that start with @ to be "internal" ([#1293], [#1294], thanks [@&#8203;jeffshaver])
> - aliased internal modules that look like core modules ([#1297], thanks [@&#8203;echenley])
> - [`namespace`]: add check for null ExportMap ([#1235], [#1144], thanks [@&#8203;ljqx])
> - [ExportMap] fix condition for checking if block comment ([#1234], [#1233], thanks [@&#8203;ljqx])
> - Fix overwriting of dynamic import() CallExpression ([`no-cycle`], [`no-relative-parent-import`], [`no-unresolved`], [`no-useless-path-segments`]) ([#1218], [#1166], [#1035], thanks [@&#8203;vikr01])
> - [`export`]: false positives for typescript type + value export ([#1319], thanks [@&#8203;bradzacher])
> - [`export`]: Support typescript namespaces ([#1320], [#1300], thanks [@&#8203;bradzacher])
> 
> ### Docs
> - Update readme for Typescript ([#1256], [#1277], thanks [[@&#8203;kirill](https://github.com/kirill)-konshin])
> - make rule names consistent ([#1112], thanks [@&#8203;feychenie])
> 
> ### Tests
> - fix broken tests on master ([#1295], thanks [@&#8203;jeffshaver] and [@&#8203;ljharb])
> - [`no-commonjs`]: add tests that show corner cases ([#1308], thanks [@&#8203;TakeScoop])
</details>
<details>
<summary>Commits</summary>

- [`b0c5e1a`](import-js/eslint-plugin-import@b0c5e1a) bump to v2.17.1
- [`f6716ad`](import-js/eslint-plugin-import@f6716ad) [fix] require v2.4 of `eslint-module-utils`
- [`5124dde`](import-js/eslint-plugin-import@5124dde) [utils] v2.4.0
- [`0499050`](import-js/eslint-plugin-import@0499050) bump to v2.17.0
- [`f479635`](import-js/eslint-plugin-import@f479635) [webpack] v0.11.1
- [`8a4226d`](import-js/eslint-plugin-import@8a4226d) Merge pull request [#1320](https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1320) from bradzacher/export-ts-namespaces
- [`988e12b`](import-js/eslint-plugin-import@988e12b) fix(export): Support typescript namespaces
- [`70c3679`](import-js/eslint-plugin-import@70c3679) [docs] make rule names consistent
- [`6ab25ea`](import-js/eslint-plugin-import@6ab25ea) [Tests] skip a TS test in eslint < 4
- [`405900e`](import-js/eslint-plugin-import@405900e) [Tests] fix tests from [#1319](https://github-redirect.dependabot.com/benmosher/eslint-plugin-import/issues/1319)
- Additional commits viewable in [compare view](import-js/eslint-plugin-import@v2.16.0...v2.17.1)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=eslint-plugin-import&package-manager=npm_and_yarn&previous-version=2.16.0&new-version=2.17.1)](https://dependabot.com/compatibility-score.html?dependency-name=eslint-plugin-import&package-manager=npm_and_yarn&previous-version=2.16.0&new-version=2.17.1)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2. developing enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @jancborchardt