feat(Message) - 🔔 add frontend support for message reminders

[Antreesy]

☑️ Resolves

• Fix Notify me later about this message - Frontend #10076
• Add an item into MessageButtonsBar (with submenu)

🖼️ Screenshots

Main menu	Sub menu

datetime.mp4

🚧 Tasks

• Manual testing
• Design review
• Code review

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not required
• 📘 API documentation in docs/ has been updated or is not required
• 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required
• 🔖 Capability is added or not needed

[DorraJaouad]

Should the chosen reminder be highlighted and/or marked on the message (e.g.: by an alarm clock next to the time)?

[nickvergessen]

We can not read existing reminders for now

[Antreesy]

Should the chosen reminder be highlighted and/or marked on the message (e.g.: by an alarm clock next to the time)?

it's not possible atm to get reminder / reminders for the specific messages, so we can't track it

[marcoambrosini]

Nice addition :)

I think that opening the date picker from within a tooltip looks bad, is unreliable and too complex. I would just add an action button that says custom and open a small dialog with the date picker.

[ShGKme]

🔔

[DorraJaouad]

Tested and all good 🦅!

In my opinion, I would recommend closing on clicking and not on hover loose for the non-custom reminders unless we want to encourage the user to set multiple reminders.

[Antreesy]

Appearance was aligned with nextcloud/server#39181 (comment)

TODO:

• add transitions for smooth animations due to different width transition isn't looking good
• apply get/delete requests with API from feat(chat): Option to get and clear reminders #10146

[ShGKme]

Tested after menu design update, everything seems to work fine, looks fine code-wise.

API request is made in a correct local timezone on both presets and custom.

[marcoambrosini]

To elaborate on my point above:

This is a pattern that we use in several places in Nextcloud that I think we should break: creating baby forms within action menus. We shouldn't include forms, especially if they involve multi-selects and pickers, into tiny action menus.

Having a text input with an inline submit button is probably ok but far from ideal, but in this case we have a baby form with a submit button that looks exactly like an actionbutton, creating visual confusion and usability issues. For example here there's no way to guarantee that the picker itself won't block the submit button below. (see screenshot)

This came up in a recent design call and there was some consensus on that we should probably even deprecate these complex action input elements. cc @nextcloud/designers

[nickvergessen]

This is a pattern that we use in several places in Nextcloud that I think we should break: creating baby forms within action menus. We shouldn't include forms, especially if they involve multi-selects and pickers, into tiny action menus.

Having a text input with an inline submit button is probably ok but far from ideal, but in this case we have a baby form with a submit button that looks exactly like an actionbutton, creating visual confusion and usability issues. For example here there's no way to guarantee that the picker itself won't block the submit button below. (see screenshot)

Well that is the result of yesterdays call was. we have less than 24h left to merge and backport the feature in 2 apps and server, so I guess miniform it is for 27.1

[nickvergessen]

I don't see a request to https://nextcloud-talk.readthedocs.io/en/latest/chat/#get-reminder-for-chat-message when opening the respective submenu and neither a "Clear reminder" option for the currently set reminder?

Ref from iOS nextcloud/talk-ios#1320 (comment)

[Antreesy]

I don't see a request

Just rebased branch and added it, please take a look

[nickvergessen]

/backport to stable27