Some errors on Firefox

[jancborchardt]

Seems it was broken on Firefox recently? cc @nextcloud/spreed any idea?


That was on our cloud.nc instance just now.

[nickvergessen]

Is it really necessary to ping 10 people by mentioning a group?

It worked fine in FF when we tried it with 4 people this afternoon. So please provide the information of the issue template:

• Browser (including version)
• Copy+paste the log so we can actually use it
• Steps that have been made to "break" it

[jancborchardt]

Is it really necessary to ping 10 people by mentioning a group?

That’s what the groups are for. Just to clarify: They were established to get people involved and not only keep the usual people on top of things. (Besides this is not relevant to this issue.)

Browser FF 50.1.0

This is the log exactly as it appears in the screenshots

TypeError: navigator.userAgent.match(...) is null simplewebrtc.js:13336:22
ReferenceError: SimpleWebRTC is not defined webrtc.js:107:3

Steps to reproduce: As said above, use our cloud.nc instance and open the Spreed app.

[nickvergessen]

This works pretty fine for me with Firefox 50.1.0 on Linux Mint (Ubuntu 16.04 based).
But reading the log messages, are you using a custom user agent? And what is your user agent (you can use services like http://www.whoishostingthis.com/tools/user-agent/ )?

[nickvergessen]

Please also open your JS console and run the following two commands:

navigator.userAgent
window.navigator.userAgent

[jancborchardt]

Aaah, thanks a lot! I was actually using an extension »User Agent Overrider« which I totally forgot about! It overrode the user agent with:

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36

(It’s a commonly used hack needed to make Netflix work with Firefox.) Any way to have the app not stumble over it? Talky.io for example had no issues with it, that’s why I thought it to be an issue on our end.

[nickvergessen]

Okay I get the same error with that user agent. Will try to find the issue.

[nickvergessen]

Well that's obvious now, the webrtc lib detect Firefox by checking whether window.mozRTCPeerConnection exists and then tries to get the Firefox version, which fails, because Firefox\/([0-9]+)\./ is not part of the user agent anymore.

Easy fix, add the actual Firefox version back into the user agent.
The only thing we can do is show a warning before breaking....