fix: reduce the global blur implementation against per conversation l…

…evel virtual background Signed-off-by: DorraJaouad <[email protected]>
nextcloud · Nov 15, 2024 · 0c8a6ad · 0c8a6ad
1 parent ab54a93
commit 0c8a6ad
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 18 deletions.
diff --git a/src/components/MediaSettings/MediaSettings.vue b/src/components/MediaSettings/MediaSettings.vue
@@ -436,20 +436,19 @@ export default {
 				this.audioOn = !BrowserStorage.getItem('audioDisabled_' + this.token)
 				this.videoOn = !BrowserStorage.getItem('videoDisabled_' + this.token)
 				this.silentCall = !!BrowserStorage.getItem('silentCall_' + this.token)
-				// Check main blur background setting
-				if (this.blurBackgroundEnabled) {
+
+				// Set virtual background depending on BrowserStorage's settings
+				if (BrowserStorage.getItem('virtualBackgroundEnabled_' + this.token) === 'true') {
+					if (BrowserStorage.getItem('virtualBackgroundType_' + this.token) === VIRTUAL_BACKGROUND.BACKGROUND_TYPE.BLUR) {
+						this.blurVirtualBackground()
+					} else if (BrowserStorage.getItem('virtualBackgroundType_' + this.token) === VIRTUAL_BACKGROUND.BACKGROUND_TYPE.IMAGE) {
+						this.setVirtualBackgroundImage(BrowserStorage.getItem('virtualBackgroundUrl_' + this.token))
+					}
+				} else if (this.blurBackgroundEnabled) {
+					// Fall back to global blur background setting
 					this.blurVirtualBackground()
 				} else {
-					// Set virtual background depending on BrowserStorage's settings
-					if (BrowserStorage.getItem('virtualBackgroundEnabled_' + this.token) === 'true') {
-						if (BrowserStorage.getItem('virtualBackgroundType_' + this.token) === VIRTUAL_BACKGROUND.BACKGROUND_TYPE.BLUR) {
-							this.blurVirtualBackground()
-						} else if (BrowserStorage.getItem('virtualBackgroundType_' + this.token) === VIRTUAL_BACKGROUND.BACKGROUND_TYPE.IMAGE) {
-							this.setVirtualBackgroundImage(BrowserStorage.getItem('virtualBackgroundUrl_' + this.token))
-						}
-					} else {
-						this.clearVirtualBackground()
-					}
+					this.clearVirtualBackground()
 				}
 
 				this.initializeDevices()
@@ -476,8 +475,9 @@ export default {
 
 		isInCall(value) {
 			if (value) {
+				const virtualBackgroundEnabled = BrowserStorage.getItem('virtualBackgroundEnabled_' + this.token) === 'true'
 				// Apply global blur background setting
-				if (this.blurBackgroundEnabled && !this.skipBlurBackgroundEnabled) {
+				if (this.blurBackgroundEnabled && !this.skipBlurBackgroundEnabled && !virtualBackgroundEnabled) {
 					this.blurBackground(true)
 				}
 			}

diff --git a/src/components/MediaSettings/VideoBackgroundEditor.vue b/src/components/MediaSettings/VideoBackgroundEditor.vue
@@ -256,11 +256,6 @@ export default {
 		},
 
 		loadBackground() {
-			// Set virtual background depending on main blur setting (in Talk settings)
-			if (this.settingsStore.blurBackgroundEnabled) {
-				this.selectedBackground = 'blur'
-				return
-			}
 			// Set virtual background depending on browser storage's settings
 			if (BrowserStorage.getItem('virtualBackgroundEnabled_' + this.token) === 'true') {
 				if (BrowserStorage.getItem('virtualBackgroundType_' + this.token) === VIRTUAL_BACKGROUND.BACKGROUND_TYPE.BLUR) {
@@ -270,6 +265,8 @@ export default {
 				} else {
 					this.selectedBackground = 'none'
 				}
+			} else if (this.settingsStore.blurBackgroundEnabled) {
+				this.selectedBackground = 'blur'
 			} else {
 				this.selectedBackground = 'none'
 			}