Using input field for monitoring endpoint url #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Kernstock <[email protected]>
Signed-off-by: Patrik Kernstock <[email protected]>
Signed-off-by: Patrik Kernstock <[email protected]>
Signed-off-by: Patrik Kernstock <[email protected]>
If there's the default margin-bottom:0 applied, the page starts flickering when the "Copy" tooltip is shown. So this is probably sort of a (working) workaround. Signed-off-by: Patrik Kernstock <[email protected]>
Signed-off-by: Patrik Kernstock <[email protected]>
|
Thanks a lot for pointing that out, @Noodlesalat! I have just pushed some new changes, including the clipboard copy feature. Now it looks like: |
Noodlesalat
reviewed
Jul 19, 2018
templates/settings-admin.php
Outdated
| <?php p($l->t('You can connect an external monitoring tool by using this end point:')); ?> | ||
| </p> | ||
| <div> | ||
| <input type="text" readonly="readonly" style="width: 415px;" id="monitoring-endpoint-url" value="<?php echo p($_['ocs']); ?>" /> |
There was a problem hiding this comment.
style="width: 415px;"
This style tag breaks on mobile devices. I think a value in percent (e.g. 70%) is better. In addition we could move this into the style.css file for better overview.
There was a problem hiding this comment.
Very good points, thanks! 80% works out great on a few tests, I think it's a good value IMO.
Signed-off-by: Patrik Kernstock <[email protected]>
|
This looks good for me now. In my opinion this can be merged! @MorrisJobke |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply replaced the monitoring endpoint url with an input field and added a listener for automatically selecting the whole url when clicking on the input field.
Should (partially) solve #90 point 4, clipboard copy functionality may still be missing.