Visual fixes and improvements #711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malex14
force-pushed
the
visual-fixes-and-improvements
branch
from
e976f54
to
cfb0ada
Compare
Signed-off-by: Malex14 <[email protected]>
Signed-off-by: Malex14 <[email protected]>
Changes in detail: - show load in percent - pined chart y max to 100% - added units to chart y-Axis - added small (by default) blue box to CPU load legend (like the one that was in the RAM legend) - added hover text to the "Load average: XX.X % (X.XX) last minute" that displays the load averages for 1, 5 and 15 minutes - added tooltip to both charts that display the cpu load / ram usage at the time where the cursor hovers. Signed-off-by: Malex14 <[email protected]>
…commented out `@media` css rules, removed remains from when the css-file was scss Signed-off-by: Malex14 <[email protected]>
Signed-off-by: Malex14 <[email protected]>
Malex14
force-pushed
the
visual-fixes-and-improvements
branch
from
cfb0ada
to
54d3785
Compare
|
I just rebased the pr on top of the current master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a lot of small CSS-Issues and improves the cpu and memory charts.
Charts
I've updated the chart library to the latest version and added a tooltip that displays the cpu / ram usage at the point of time where the cursor hovers over the chart. Additionally the cpu chart and legend show the usage now in percent (instead of 0 to cpu count) and has its y max fixed at 100%. I've also added a hover text to the cpu legend that displays the averages of the past 1, 5 and 15 minutes. Also the y-Axis is now readable in dark mode:
Click to show screenshots
Original:
Improved:
Overflowing Boxes
To fix the mobile overflows, I mostly just reenabled the commented out
@mediarules. But a few other changes had to be made too:Click to show screenshots
Original:
Improved:
Overlapping Text
Lastly there was some overlapping text in the "External monitoring tool" section:
Click to show screenshots
Original:
Improved: