-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename DefaultOs to Linux #488
Conversation
59ffb61
to
95bb721
Compare
So depending on the detected OS, the app tries to gather system info via common commands/APIs. And the Definitely better than before with Linux actually named Linux and a universally compatible fallback/default OS, which additionally can be used when external commands/APis are explicitly not wanted or available. But I find the name "default" not very intuitive code-wise and for the CLI/setting. What about calling it |
Suggestion:
|
Thank you very much for your feedback 🙌 I couldn't come up with a better name, so I stayed with DefaultOs 🤣
Afaik PHP_OS is set on compilation: https://github.com/php/php-src/blob/6f6fedcb46a27cd3530f0babc9b03ce4598f9eab/configure.ac#L1498-L1499
Good to know, I wasn't aware. |
Indeed, no point then to allow enforcing anything else than the dummy. Two concurrently written feedback comments with the same point(s) about the naming 💯. "dummy", "skeleton", "base", "basic", "bare", "minimal" ... "fallback"? If it acted like a template, "base" would fit best. But here it is an independent class which just implements the same interface, so "dummy" or "minimal" probably fit better. The setting could then be called |
9b06183
to
080fffe
Compare
Thanks for your valuable input 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, for admins as well as for developers it is nicely understandable now.
Signed-off-by: Daniel Kesselberg <[email protected]>
DefaultOs was actually the implementation for Linux.