Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A desperate second attempt to fix #263 #425

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dertuxmalwieder
Copy link

Based upon the FreeBSD implementation and my own previous attempt... VERY lightly tested.

…SD implementation and my own previous attempt... VERY lightly tested.
@kesselb
Copy link
Collaborator

kesselb commented Apr 23, 2023

Thanks for your pull request 👍

I'm not sure how to continue here. The linter and static analysis are failing. That's something we have to fix.

I took your changes a few weeks ago and tried to add some tests: https://github.com/nextcloud/serverinfo/compare/feat/sun-os

The current implementation is a bit unfinished.
Sorry, I can't spare the time to finish the unit tests, but I'm happy to answer your questions.

fixed a few copy&paste problems

Signed-off-by: Cthulhux <[email protected]>
@dertuxmalwieder
Copy link
Author

The current implementation is a bit unfinished.

Yes, I noticed that I made a few mistakes there, some of which caused by copy&paste after the initial version. Sorry for have wasted your time with that. That happens when you (= I) don't give myself enough time... I changed a few things, but yes, the lack of tests is a problem on my side. I wish I wouldn't even had to do that again though ... ;-)

@kesselb kesselb marked this pull request as draft June 28, 2023 13:19
@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
@skjnldsv skjnldsv removed this from the Nextcloud 29.0.1 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants