New search standard and user search

[skjnldsv]

This is a tricky one!
Fixes #2657

• Added support for user search in the new users vue list
• Added support for simple registration of a search in javascript
  • new OCA.Search(searchfunction, resetfunction)
  • Any app can register this with plain pure js and simply add its manager.
• Deprecated OCA.Search is now OCA.Search.Core to ensure devs migrate their search system to this as well.
• Fixed design of the global search in Files

[MorrisJobke]

Conflicts :/

[juliusknorr]

👍 Works nicely also with multiple instances on one page.

[MorrisJobke]

I added one user "test1" and searched for "test", then I got one result, then two, then three and it stopped after 4:

Same happens with two users in the result set:

[codecov]

Codecov Report

Merging #9912 into master will increase coverage by 0.01%.
The diff coverage is 9.75%.

@@             Coverage Diff             @@
##             master   #9912      +/-   ##
===========================================
+ Coverage     52.08%   52.1%   +0.01%     
  Complexity    25910   25910              
===========================================
  Files          1642    1642              
  Lines         95898   95721     -177     
  Branches       1318    1289      -29     
===========================================
- Hits          49950   49873      -77     
+ Misses        45948   45848     -100

Impacted Files	Coverage Δ	Complexity Δ
core/templates/layout.user.php	0% <0%> (ø)	0 <0> (ø)	⬇️
lib/private/legacy/template.php	30.32% <100%> (+0.91%)	42 <0> (ø)	⬇️
core/search/js/search.js	9.52% <5.26%> (-28.49%)	0 <0> (ø)
apps/files_trashbin/lib/Expiration.php	91.93% <0%> (+1.61%)	29% <0%> (ø)	⬇️

[skjnldsv]

@MorrisJobke done

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

I found another small issue:

• open the apps management
• type in the search term
• press enter
• before: it did nothing and just searched
• after: it does a POST request resulting in a white page

[skjnldsv]

@MorrisJobke the app management need to be updated to this standard as well, I'll handle it in a sec :)

[kyrofa]

This line is wreaking havoc on my automated tests, throwing this on the login page:

TypeError: document.getElementById(...) is null in search.js:84:4
	initialize http://localhost/core/search/js/search.js:84:4
	Search http://localhost/core/search/js/search.js:37:3
	initialize http://localhost/core/search/js/searchprovider.js:384:11
	Search http://localhost/core/search/js/searchprovider.js:34:3
	<anonymous> http://localhost/core/search/js/searchprovider.js:432:16
	_.delay/< http://localhost/core/vendor/core.js:781:14

Firefox shows this as well.

[skjnldsv]

It's a deeper issue as there is no real reason why the search needs to me initiated on the login page :p

[nickvergessen]

Since this patch the search icon/bar is visible on any app again, although there might not be search functionality available, eg activity, talk, settings, …

Can we do something about this?

[skjnldsv]

@nickvergessen this shouldn't. Who is registering the search on those apps?

[nickvergessen]

I added a break point at console.debug('New search handler registered');

initialize (search.js#63)
Search (search.js#37)
initialize (searchprovider.js#384)
Search (searchprovider.js#34)
(anonym) (searchprovider.js#432)
(anonym) (underscore.js#768)

¯\(ツ)/¯

[skjnldsv]

This registration shouldn't be there on every page :/