Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NULL users? #8765

Closed
wants to merge 1 commit into from
Closed

Fix NULL users? #8765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/private/Group/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ public function isInGroup($userId, $group) {
* @param IUser $user
* @return array with group ids
*/
public function getUserGroupIds(IUser $user) {
public function getUserGroupIds(IUser $user = null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather fix the code that calls the method incorrectly than fixing it here. See #8765 (comment)

return array_map(function($value) {
return (string) $value;
}, array_keys($this->getUserGroups($user)));
Expand Down